Use Crystal 0.34 Log module (if possible) #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Mar 25, 2020
f-fr
pushed a commit
to f-fr/shards
that referenced
this pull request
Jan 2, 2021
Use Crystal 0.34 Log module (if possible)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I migrate shards code to use Log module API.
But allow compilation for logger module behind compare_versions.
Once we drop support for older Crystal that can be removed.
With the log module we could even be able to allow logging from molinillo solver be tweaking
CRYSTAL_LOG_SOURCES. How cool is that 馃槏