Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obosolete Dependency#to_human_requirement #356

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Apr 17, 2020

This is now unused and broken code after #354

Copy link
Member

@waj waj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this reminds me I need to override to_s in requirements or delegate that to the Resolver. Otherwise this wont look nice when printing conflicts. I'll fix that and add some tests.

@waj waj merged commit 49df619 into crystal-lang:master Apr 17, 2020
@straight-shoota straight-shoota deleted the refactor/cleanup branch April 17, 2020 21:36
@bcardiff bcardiff added this to the v0.11.0 milestone May 27, 2020
taylor pushed a commit to vulk/shards that referenced this pull request Aug 11, 2020
f-fr pushed a commit to f-fr/shards that referenced this pull request Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants