Fix: shard.lock is always overwritten even when dependencies are up to date #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waj
force-pushed
the
fix/shard-lock-overwrite
branch
from
b24a7d9
to
a63f13d
Compare
bcardiff
approved these changes
Apr 29, 2020
straight-shoota
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
There's surely a more efficient way than map, to_h and compare. Might not be super relevant here, but the code just looks quite off with so many transformations just to tell whether the locked versions match. Maybe sort + zip compare could be a better alternative?
|
map block to_h is simply to_h block |
|
@asterite is a little bit rude (and intimidating) to read the mind of others |
|
:-) Sorry for the brevity, cellphone |
taylor
pushed a commit
to vulk/shards
that referenced
this pull request
Aug 11, 2020
f-fr
pushed a commit
to f-fr/shards
that referenced
this pull request
Jan 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #354 unchanged locks are undetected and always overwritten after the "install" command