Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be seen as a silly thing but it could be actually pretty annoying sometimes. I know some terminals have settings to ensure minimal contrast but I think it's better not to rely on that configuration.
Because we cannot aim for any background color, I just tested with the extremes: black and white. For each case, here is how it looks before and after the change. Bright colors look great on dark background, but I can barely see WARN on the light background. BTW,
bundler
uses the same colors.