Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use less bright colors for output #373

Merged
merged 1 commit into from
May 4, 2020
Merged

Use less bright colors for output #373

merged 1 commit into from
May 4, 2020

Conversation

waj
Copy link
Member

@waj waj commented Apr 30, 2020

This might be seen as a silly thing but it could be actually pretty annoying sometimes. I know some terminals have settings to ensure minimal contrast but I think it's better not to rely on that configuration.

Because we cannot aim for any background color, I just tested with the extremes: black and white. For each case, here is how it looks before and after the change. Bright colors look great on dark background, but I can barely see WARN on the light background. BTW, bundler uses the same colors.

Screen Shot 2020-04-29 at 15 33 14

Screen Shot 2020-04-29 at 15 33 48

Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How color codes are reprsented depends on the terminal's color scheme, so we shouldn't bother about specific details that might already look different on the next machine.
But using all colors from the same family (non-light) seems reasonable.

@waj waj merged commit b0ac977 into crystal-lang:master May 4, 2020
@waj waj deleted the colors branch May 4, 2020 14:10
@bcardiff bcardiff added this to the v0.11.0 milestone May 27, 2020
taylor pushed a commit to vulk/shards that referenced this pull request Aug 11, 2020
f-fr pushed a commit to f-fr/shards that referenced this pull request Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants