Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Makefile envvars to be overwritten from a command line #378

Merged
merged 1 commit into from
May 4, 2020

Conversation

anatol
Copy link
Contributor

@anatol anatol commented May 3, 2020

Signed-off-by: Anatol Pomozov anatol.pomozov@gmail.com

@RX14
Copy link
Contributor

RX14 commented May 3, 2020

Shouldn't CRYSTAL and SHARDS be overwritable too?

@anatol
Copy link
Contributor Author

anatol commented May 3, 2020

If you think that build process needs to customize it then yes. These two envvars need to be overwritable.

@RX14
Copy link
Contributor

RX14 commented May 3, 2020

It'd be useful, like CC.

Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com>
@waj waj merged commit c63c9a3 into crystal-lang:master May 4, 2020
@bcardiff bcardiff added this to the v0.11.0 milestone May 27, 2020
f-fr pushed a commit to f-fr/shards that referenced this pull request Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants