Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error on duplicate arguments in shard.yml #387

Merged
merged 2 commits into from
May 12, 2020

Conversation

straight-shoota
Copy link
Member

Resolves #376

@waj
Copy link
Member

waj commented May 12, 2020

This is ok, and I'll merge it right away because it solves the issue. But I wonder if the YAML parser shouldn't have an option to be strict in this case. Note that this solution only handles duplicates at the top level, but it ignores on other places.

@waj waj added this to the v0.11.0 milestone May 12, 2020
@waj waj merged commit 10bc0a8 into crystal-lang:master May 12, 2020
@straight-shoota straight-shoota deleted the fix/duplicate-keys branch May 12, 2020 22:47
@straight-shoota
Copy link
Member Author

Yeah, I'd also like to add a feature to the parser. Same goes for JSON, too, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate keys in spec
3 participants