Make errors with git refs more descriptive #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a shard.yml is not found by ref
bcardiff
approved these changes
May 18, 2020
straight-shoota
approved these changes
May 18, 2020
taylor
pushed a commit
to vulk/shards
that referenced
this pull request
Aug 11, 2020
f-fr
pushed a commit
to f-fr/shards
that referenced
this pull request
Jan 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a git ref doesn't exist, the resolver just returns an empty array for the available versions. This makes the solver to fail with a confusing message. For example:
With this PR, the error is handled more prematurely, thus providing better info:
Also, if a commit hash is used, the full hash is displayed:
Related to #384, #386