Add convenient makefile arguments for packaging #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When packaging shards is usually compiled with --no-debug and --release. This change will allow using the makefile in those scripts. Otherwise we need to manually use the crystal build or CRYSTAL_OPTS env var
Same as the ones found in crystal-lang/crystal
jhass
approved these changes
Jun 23, 2020
straight-shoota
approved these changes
Jun 23, 2020
taylor
pushed a commit
to vulk/shards
that referenced
this pull request
Aug 11, 2020
* Allow make all FLAGS="--no-debug --release" When packaging shards is usually compiled with --no-debug and --release. This change will allow using the makefile in those scripts. Otherwise we need to manually use the crystal build or CRYSTAL_OPTS env var * Add release debug static makefile arguments Same as the ones found in crystal-lang/crystal
f-fr
pushed a commit
to f-fr/shards
that referenced
this pull request
Jan 2, 2021
* Allow make all FLAGS="--no-debug --release" When packaging shards is usually compiled with --no-debug and --release. This change will allow using the makefile in those scripts. Otherwise we need to manually use the crystal build or CRYSTAL_OPTS env var * Add release debug static makefile arguments Same as the ones found in crystal-lang/crystal
|
Looks like the README build instructions are now wrong due to these changes. |
|
Good catch @taylorthurlow. The README is indeed outdated regarding the CRFLAGS (since #344). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to crystal-lang/crystal#9471
Follow-up to crystal-lang/distribution-scripts#71 (comment)
I'm only adding release, debug, static to use the same in crystal repo. But I think having FLAGS is enough.