Add --ignore-crystal-version related suggestion and warnings to guide user #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhass
approved these changes
Jun 25, 2020
bcardiff
force-pushed
the
featurer/suggest-ignore
branch
from
617a301
to
a45385f
Compare
when those shards were installed due to --ignore-crystal-version option it will also warn if the option was specified but not needed
bcardiff
changed the title
|
I've added a couple of warnings to help the user
|
waj
approved these changes
Jul 21, 2020
taylor
pushed a commit
to vulk/shards
that referenced
this pull request
Aug 11, 2020
… user (crystal-lang#418) * Add --ignore-crystal-version suggestion when conflict on crystal * Rephrase suggestions * Add warning regarding incompatible shards when those shards were installed due to --ignore-crystal-version option it will also warn if the option was specified but not needed
f-fr
pushed a commit
to f-fr/shards
that referenced
this pull request
Jan 2, 2021
… user (crystal-lang#418) * Add --ignore-crystal-version suggestion when conflict on crystal * Rephrase suggestions * Add warning regarding incompatible shards when those shards were installed due to --ignore-crystal-version option it will also warn if the option was specified but not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.