Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SHARDS_OPTS/--ignore-crystal-version in build & default command #420

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

bcardiff
Copy link
Member

Follow up of #417.

Add --ignore-crystal-version as OptionParser option so the

shards --ignore-crystal-version
or
SHARDS_OPTS=--ignore-crystal-version shards

do not pick --ignore-crystal-version as the command name in args[0]?

Add --ignore-crystal-version as OptionParser option so the 

shards --ignore-crystal-version 
or
SHARDS_OPTS=--ignore-crystal-version shards

do not pick --ignore-crystal-version as the command name in args[0]?
@bcardiff bcardiff merged commit 2a87638 into crystal-lang:master Jul 16, 2020
@bcardiff bcardiff deleted the fix/shard-opts branch July 21, 2020 20:36
@waj waj added this to the v0.12.0 milestone Jul 28, 2020
taylor pushed a commit to vulk/shards that referenced this pull request Aug 11, 2020
…crystal-lang#420)

Add --ignore-crystal-version as OptionParser option so the 

shards --ignore-crystal-version 
or
SHARDS_OPTS=--ignore-crystal-version shards

do not pick --ignore-crystal-version as the command name in args[0]?
f-fr pushed a commit to f-fr/shards that referenced this pull request Jan 2, 2021
…crystal-lang#420)

Add --ignore-crystal-version as OptionParser option so the 

shards --ignore-crystal-version 
or
SHARDS_OPTS=--ignore-crystal-version shards

do not pick --ignore-crystal-version as the command name in args[0]?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants