Bump required crystal to 0.35 #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise make lib target will trigger on CI because the shard.lock version is overwritten by shards install _after_ the creation of lib folder. Since Crystal 0.35 ships with shards 0.11 which supports lock version 2.0, and required crystal was bumped in previous commit we can make this change now.
waj
approved these changes
Jul 24, 2020
taylor
pushed a commit
to vulk/shards
that referenced
this pull request
Aug 11, 2020
* Bump requirement for Crystal >= 0.35 * Update shard.lock to version 2.0 Otherwise make lib target will trigger on CI because the shard.lock version is overwritten by shards install _after_ the creation of lib folder. Since Crystal 0.35 ships with shards 0.11 which supports lock version 2.0, and required crystal was bumped in previous commit we can make this change now. * Test nightly on every commit also * Memoize crystal_path in specs
f-fr
pushed a commit
to f-fr/shards
that referenced
this pull request
Jan 2, 2021
* Bump requirement for Crystal >= 0.35 * Update shard.lock to version 2.0 Otherwise make lib target will trigger on CI because the shard.lock version is overwritten by shards install _after_ the creation of lib folder. Since Crystal 0.35 ships with shards 0.11 which supports lock version 2.0, and required crystal was bumped in previous commit we can make this change now. * Test nightly on every commit also * Memoize crystal_path in specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code cleanups plus followup for #421 馃槥