Use git's checkout feature directly to write out repo files
#435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid relying on a shell to pipe into `tar`. Caveat: `git checkout` also updates the index in the repository, but that shouldn't be a problem here (is there even any index in a bare repo to start with?) This is part of work to bring 'shards' to Windows.
5 tasks
jhass
approved these changes
Sep 20, 2020
straight-shoota
approved these changes
Oct 30, 2020
5 tasks
|
What's the holdup with this particular pull request (the last one)? 😅 |
|
I was waiting for CI to finish after I fixed the merge conflict. Not sure why the milestone was changed. It should be ready to merge right away. |
|
I changed the milestone because v0.12.0 is released already, but the milestone was not closed. I created a vNext because I'm not sure the next is 0.12.1 or 0.13.0 |
|
Thanks @oprypin |
f-fr
pushed a commit
to f-fr/shards
that referenced
this pull request
Jan 2, 2021
…l-lang#435) to avoid relying on a shell to pipe into `tar`. Caveat: `git checkout` also updates the index in the repository, but that shouldn't be a problem here (is there even any index in a bare repo to start with?) This is part of work to bring 'shards' to Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid relying on a shell to pipe into
tar.Caveat:
git checkoutalso updates the index in the repository, but that shouldn't be a problem here (is there even any index in a bare repo to start with?)This is part of work to bring 'shards' to Windows.