Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve git reliability by retrying on failures #450

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

fudanchii
Copy link
Contributor

Occasionally, though it's always happen with my connection, either git clone --mirror or git fetch --all via http will tend to fail with closed connection.

2020-12-04_06-05

Doing retry directly on the git command seem to fix the situation. In addition, bundle also doing this with their git_proxy
2020-12-04_06-02

Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@straight-shoota straight-shoota merged commit 62ca129 into crystal-lang:master Dec 7, 2020
@straight-shoota
Copy link
Member

Thanks @fudanchii

f-fr pushed a commit to f-fr/shards that referenced this pull request Jan 2, 2021
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
@bcardiff bcardiff added this to the vNext milestone Jan 21, 2021
@fudanchii fudanchii deleted the do-retry-on-git branch May 7, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants