Spec: Allow empty scalar for mappings/sequences #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows empty scalars as values for mappings or sequences in
shard.yml.So this is considered a valid specification:
Previously, this caused a YAML parser error:
Expected MAPPING_START but was SCALAR at line 3, column 15There's no change to internal behaviour because empty mappings and sequences were already allowed (
dependencies: {}).So this is just a simple UX feature that avoids errors when for example all dependencies are removed but the
dependencies:key isn't.Both empty string and YAML null value (
~) are accepted.