-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macOS nightlies to CI #464
Conversation
This could be merged... |
@bcardiff Could you please review this? |
Is there a reason to exclude windows from using crystal latest? |
And the reason for that is crystal-lang/distribution-scripts#64 (comment) |
@Sija Why do you have to change the whole file's formatting to adhere to your liking? |
@oprypin Whole file? Don't exaggerate, adding some spaces for readability and changing name of one job is not whole file. What's wrong with those changes anyway? |
@Sija They are irrelevant to the change you want to make. If you want to change someone else's style, I think that should be discussed and done separately. Code is written by people if you go and change that when it's not needed, while also adding additional changes, the ones that wrote the original code might think "What's your problem with my style? BAM. I don't like your PR." Not that that will effectively happen. But at least in my case when I contribute to a project I tend to avoid changing style things if they have nothing to do with the PR's goal. |
They also make reviewing the PR harder! "Why was this changed? Is this relevant? I don't understand." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine the changes. Let's keep it calm. But I agree that changes that satisfies author's taste should be avoided in general.
Refactored some parts as well like
include
-ing windows in thematrix
instead of having it there from start - especially apt as windows support is still in-the-works.