Add --skip-postinstall cli option to install and update #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
straight-shoota
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements the suggestions of #468 (comment)
The postinstall instructions will be logged with a trailing
(skipped).Usually the postinstall will generate target binaries that are then linked/copied by
Package#install_executables.With this PR the target binaries will not exist and wont be linked/copied, which is fine.
To complete the idea #468 (comment) and decouple the commands for Windows environments in a comfortable way I am not sure if it's better to a) make the
shards postinstall --dry-run [shard names]perform postinstall and install_executables or if b) postinstall and install-executables should be different commands.Either way that can be handled in a separate PR. This should be enough to download dependencies with postinstall in Windows.