Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message for invalid shard.yml #516

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Fix error message for invalid shard.yml #516

merged 1 commit into from
Aug 23, 2021

Conversation

straight-shoota
Copy link
Member

Resolves #510

@jwoertink jwoertink mentioned this pull request Jul 29, 2021
Closed
beta-ziliani
beta-ziliani approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@beta-ziliani beta-ziliani added this to the vNext milestone Aug 18, 2021
@straight-shoota straight-shoota merged commit 456e46a into crystal-lang:master Aug 23, 2021
@straight-shoota straight-shoota deleted the fix/error-message-invalid-spec branch August 23, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees
No one assigned
Labels
kind:bug
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

No shard.yml was found for shard ... at commit ... (incorrect error message)
2 participants
@straight-shoota @beta-ziliani