Avoid user defined git template in resolver #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have couple of hooks in my global git template (skeleton) directory, this breaks shards completely and it was such a pain to figure it out. Symptoms are: ``` Resolving dependencies Fetching https://github.com/will/crystal-pg.git Installing pg (0.24.0) Failed git --work-tree=/home/lzap/work/invidious/lib/pg checkout refs/tags/v0.24.0 -- . (). Maybe a commit, branch or file doesn't exist? ```
|
Hmmm are failures really relevant? I am trying to navigate through it, this is weird. |
caspiano
approved these changes
Mar 4, 2022
straight-shoota
approved these changes
Mar 8, 2022
bcardiff
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have couple of hooks in my global git template (skeleton) directory, this breaks shards completely and it was such a pain to figure it out. Symptoms are:
The patch overrides the user-defined configuration so git checkouts are clean.