Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust parameter name for Resolver#install_sources #559

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Sep 6, 2022

All implementations of #install_sources have a second parameter called install_path, only the abstract definition in Resolver uses the name install_dir, which results in a warning:

positional parameter 'install_path' corresponds to parameter 'install_dir' of the overridden method Shards::Resolver#install_sources(version : Version, install_dir : String), which has a different name and may affect named argument passing

This patch renames the parameter name in the abstract definition to match the one used in all the implementations.

@straight-shoota straight-shoota added this to the v0.18.0 milestone Sep 6, 2022
@straight-shoota straight-shoota merged commit bf26743 into crystal-lang:master Sep 21, 2022
@straight-shoota straight-shoota deleted the fix/adjust-corresponding-parameter-name branch September 21, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants