Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ensure manpages are generated with no diff #594

Merged

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Jul 19, 2023

Manpages in man/ are generated from adoc files in docs/. Both source and target format are checked into git.
Often it's forgotten to update the manpages when the adoc sources are updated (latest example: #587).

This change ensures that the manpages are up to date in CI by rebuilding them and checking if they produce a diff.

@beta-ziliani
Copy link
Member

Can you explain the issue?

@straight-shoota
Copy link
Member Author

straight-shoota commented Jul 19, 2023

Yeah, added it to he OP. Sorry, I was deep in a rabbit hole 😆

@straight-shoota straight-shoota merged commit 4bf845f into crystal-lang:master Jul 23, 2023
7 checks passed
@straight-shoota straight-shoota deleted the ci/test-manpages-nodiff branch July 23, 2023 20:39
@straight-shoota straight-shoota added this to the 0.18.0 milestone Dec 19, 2023
kojix2 pushed a commit to kojix2/shards that referenced this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants