Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Selenium::Element#submit #26

Merged
merged 1 commit into from Feb 28, 2023
Merged

implement Selenium::Element#submit #26

merged 1 commit into from Feb 28, 2023

Conversation

mamantoha
Copy link
Contributor

@mamantoha mamantoha commented Feb 20, 2023

Inspired from Ruby and Python implementations

@mamantoha
Copy link
Contributor Author

If you are wonder about ELEMENT_KEY = "element-6066-11e4-a52e-4f735466cecf" check https://www.w3.org/TR/2015/WD-webdriver-20150827/

image

@matthewmcgarvey
Copy link
Collaborator

Hey @mamantoha , I'm happy with this change, you've just got the failing format check if you could fix that.

@mamantoha
Copy link
Contributor Author

Hi @matthewmcgarvey . Ameba linter fails are not related to changes in this PR. This is due new version of ameba being released.
You can merge and then run ./bin/ameba --fix.
Or I can fix the warning here. What should I do?

@matthewmcgarvey
Copy link
Collaborator

Ahh, sorry about that. I fixed it myself, and thank you for helping out!

@matthewmcgarvey matthewmcgarvey merged commit eda762d into crystal-loot:master Feb 28, 2023
@mamantoha mamantoha deleted the feature/selenium-element-submit branch February 28, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants