Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of compiler versions for excercises #249

Closed
Murat-U-Saglam opened this issue Mar 15, 2023 · 4 comments
Closed

Lack of compiler versions for excercises #249

Murat-U-Saglam opened this issue Mar 15, 2023 · 4 comments

Comments

@Murat-U-Saglam
Copy link

Just wondering if the absence of pragma solidity x.x.x; of the solidity files within this area of the repo is intentional, if so why? Makes it a bit inconvenient when testing and I am not sure if any exercises are dependent on a specific compiler version.
@0xPhaze
Copy link
Contributor

0xPhaze commented Mar 16, 2023

You're right, some exercise depend on a specific version. We are working on a refactor that will these. I will let you know once it's complete.

@0xPhaze 0xPhaze closed this as completed Mar 28, 2023
@0xPhaze
Copy link
Contributor

0xPhaze commented Mar 28, 2023

Completed in

@Murat-U-Saglam
Copy link
Author

The changes seem to be for only exercise 1, I'm assuming the latest compiler version for the other exercises is appropriate.

@0xPhaze
Copy link
Contributor

0xPhaze commented Mar 29, 2023

There were additional PRs, I only listed the first. The required versions should be included in all relevant files now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Murat-U-Saglam @0xPhaze