Windows CI for crytic-compile #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is currently broken, and tries to pull a repository via git:// which GH Actions now blocks.
We will need it to run CI on Windows
If autocrlf is enabled on Windows, it will rewrite solc code with CRLF file endings and break tests that depend on byte offsets in the code files.
This also extracts Node setup from individual scripts into the workflow, to support running on Windows.
|
Looks like we are failing because of builder in windows. This platform is not supported anymore (its hardhat), maybe we can remove it from windows in the CI? |
|
Now that #248 is merged it should work fine, but if it continues to fail I can drop it from the Windows runs 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Windows runs to the crytic-compile workflows. Some of the runs may fail until #248 is merged.
This PR also fixes the 'solc' test, which has been silently broken for a while.