Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etherscan: don't compress paths containing "contracts" #332

Conversation

SheldonHolmgren
Copy link
Contributor

@SheldonHolmgren SheldonHolmgren commented Dec 29, 2022

Partially fixes #150. After this patch slither successfully runs for 2 of the 3 addresses (0xcE4a49d7ed99C7c8746B713EE2f0C9aA631688d8 and 0x640022f8a9f00992fa63ee6bae25c2829deadd2d) mentioned in that issue. The other target still fails, this time with a different error (File outside of allowed directories instead of File not found.):

$ crytic-compile 0x2a311e451491091d2a1d3c43f4f5744bdb4e773a
...
ParserError: home/cluracan/code/0x-protocol/contracts/zero-ex/node_modules/@0x/contracts-erc20/contracts/src/v06/LibERC20TokenV06.sol:23:1: ParserError: Source "@0x/contracts-utils/contracts/src/v06/LibBytesV06.sol" not found: File outside of allowed directories.
import "@0x/contracts-utils/contracts/src/v06/LibBytesV06.sol";
^-------------------------------------------------------------^

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2022

CLA assistant check
All committers have signed the CLA.

@montyly
Copy link
Member

montyly commented Jan 9, 2023

Hi @SheldonHolmgren. Thank you for the contribution. We ended up taking a different approach with #345

@montyly montyly closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Etherscan: improve multi files support
3 participants