Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC improvements (chain id, config options) #1017

Merged
merged 3 commits into from
Apr 7, 2023
Merged

RPC improvements (chain id, config options) #1017

merged 3 commits into from
Apr 7, 2023

Conversation

arcz
Copy link
Member

@arcz arcz commented Apr 6, 2023 •
edited

This PR is a mixture of various improvements to RPC and config:

  • new config options rpcUrl, rpcBlock, coverageReport
  • the env vars override the configured url/block
  • renamed Echidna.RPC module to Echidna.Etheno
  • renamed Echidna.Fetch module to Echidna.Deploy
  • moved many RPC-related functions to Echidna.RPC
  • chain id is fetched when RPC is configured
  • opt-out from generating coverage report with coverageReport: false to speed things up when the report is not needed
  • fetch external contracts sources for Ethereum Mainnet only

@arcz arcz requested a review from ggrieco-tob as a code owner April 6, 2023 20:13
@arcz arcz merged commit 2fea6ba into master Apr 7, 2023
15 checks passed
@arcz arcz deleted the arcz/chainid branch April 7, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrieco-tob ggrieco-tob Awaiting requested review from ggrieco-tob ggrieco-tob is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@arcz