Clean up Docker containers #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep the same distro we were using previously
elopez
force-pushed
the
docker-slim
branch
3 times, most recently
from
c8c4b8f
to
b6b476e
Compare
Try fixing missing __xmknod symbol with ubuntu jammy
Otherwise the final environment is slightly broken if someone tries to install extra packages
Echidna prints emojis and will throw an error if the locale is not set correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several changes to the Dockerfile and GitHub Actions used to build the echidna docker container to achieve the following:
Single point of distribution: Docker Hub is dropped, and images are only published on GitHub Container Registry nowubuntu(~160M) which ships with a shell, apt-get and nvm, anddistroless(~100M) which is just echidna and python dependencies. Distroless is currently disabled and left as reference to keep things simple. The current docker image is ~680M.docker/metadata-action.gha(GitHub Actions) cache type to reduce build times.The README section on Docker is also updated to account for the changes in this PR.