Merge pull request #813 from crytic/dev-controlled-array-fp

Remove false positive on array length detector
crytic · Mar 28, 2021 · 719d22c · 719d22c
2 parents 965376a + f998018
commit 719d22c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/scripts/ci_test_etherlime.sh b/scripts/ci_test_etherlime.sh
@@ -15,7 +15,7 @@ npm i -g etherlime
 etherlime init
 slither .
 
-if [ $? -eq 8 ]
+if [ $? -eq 7 ]
 then
     exit 0
 fi

diff --git a/slither/detectors/statements/array_length_assignment.py b/slither/detectors/statements/array_length_assignment.py
@@ -103,6 +103,9 @@ def _detect(self):
         Detect array length assignments
         """
         results = []
+        # Starting from 0.6 .length is read only
+        if self.slither.solc_version >= "0.6.":
+            return results
         for contract in self.contracts:
             array_length_assignments = detect_array_length_assignment(contract)
             if array_length_assignments: