False positive on contracts-that-lock-ether

[mrice32]

Forwarding ether to another contract in a payable method seems to incorrectly trigger the locking warning despite the fact that all ether is forwarded rather than stored. As with #112, feel free to close if this is not the right forum or this error is working as intended. See the following example that triggers the error:

/*
  Test
*/
pragma solidity >=0.4.24;


contract OtherContract {
    address public owner;

    modifier onlyOwner {
        require(msg.sender == owner);
        _;
    }

    constructor(address ownerAddress) public payable {
        owner = ownerAddress;
    }

    function withdraw() external onlyOwner {
        msg.sender.transfer(address(this).balance);
    }
}


contract TestContract {
    function createOtherContract() external payable returns (address newContract) {
        OtherContract otherContract = (new OtherContract).value(msg.value)(msg.sender);
        return address(otherContract);
    }
}

[montyly]

Hey @mrice32 , thank you for reporting the issue

LockedEther was not considering the transfer of ether through new contract operations. It is fixed in master