Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suicidal detector fails on external functions #527

Closed
wolflo opened this issue Jul 8, 2020 · 3 comments
Closed

Suicidal detector fails on external functions #527

wolflo opened this issue Jul 8, 2020 · 3 comments
Labels
enhancement New feature or request High Priority

Comments

@wolflo
Copy link

wolflo commented Jul 8, 2020

If the example function for the suicidal detector is changed from public to external the issue is no longer flagged.

pragma solidity ^0.5.0;
contract Suicidal{
    function kill() external{
        selfdestruct(msg.sender);
    }
}

slither --version: 0.6.12
solc --version: 0.5.15

@montyly montyly added enhancement New feature or request High Priority labels Jul 9, 2020
@montyly
Copy link
Member

montyly commented Jul 9, 2020

Hi @wolflo,

Thank you for reporting this. I agree that external functions should be included in this detector, we will include them.

montyly added a commit that referenced this issue Jul 12, 2020
Clean the suicidal detector to use functions_entry_points
@montyly
Copy link
Member

montyly commented Jul 19, 2020

Hi @wolflo, the fix (#530) is merged in master.

It will also be available in the upcoming release.

Thank you again for reporting this issue

@wolflo
Copy link
Author

wolflo commented Jul 19, 2020

Thanks for the fix @montyly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request High Priority
Projects
None yet
Development

No branches or pull requests

2 participants