update setup.py with dev dependencies and update CI #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xalpharush
force-pushed
the
dev-dependencies
branch
from
b3576b9
to
a880e09
Compare
montyly
reviewed
Apr 21, 2022
elopez
reviewed
Apr 21, 2022
.github/workflows/linter.yml
Outdated
Comment on lines
32
to
33
| pip install . | ||
| pip install deepdiff numpy | ||
| pip install ".[dev]" | ||
| pip install numpy |
There was a problem hiding this comment.
Same here, I think we can drop these.
Make the --checklist flag public Improve documentation of the related flags
0xalpharush
force-pushed
the
dev-dependencies
branch
from
c59ca3e
to
1414de0
Compare
|
Fix #1194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to only update the setup.py without having to edit each CI test. Also it ensures that our development environments stay up to date (pylint and black, in particular).