Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile and add Actions workflow to build it #1335

Merged
merged 5 commits into from
Aug 15, 2022
Merged

Update Dockerfile and add Actions workflow to build it #1335

merged 5 commits into from
Aug 15, 2022

Conversation

elopez
Copy link
Member

@elopez elopez commented Aug 10, 2022 •
edited

This PR:

  • updates the Dockerfile base to Ubuntu Jammy (22.04)
  • separates build and install processes into two stages
  • replaces fixed solc binary with solc-select
  • adds a workflow that builds the container for
    • linux/amd64 (x86_64 systems),
    • linux/arm64 (ARM 64-bit systems, eg. Mac M1 with Docker Desktop)
    • linux/arm/v7 (ARM 32-bit systems, eg. some SBC systems)
  • publishes the container on GHCR:
    • matching tagged builds for tag releases,
    • edge tag matching the latest master commit
    • latest tag matching the latest release
    • testing-foo matching the latest commit in branch foo (must be also enabled in the workflow on: .. section)

Closes: #937, #1330

@elopez elopez requested a review from montyly August 10, 2022 11:18
@elopez elopez linked an issue Aug 10, 2022 that may be closed by this pull request
Simplify our docker file #1330
Closed
3 tasks
@elopez elopez marked this pull request as ready for review August 10, 2022 11:31
@montyly montyly changed the base branch from master to dev August 11, 2022 12:46
@montyly montyly merged commit eeeb8bf into crytic:dev Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montyly montyly Awaiting requested review from montyly montyly is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify our docker file Dockerizing latest for Apple M1 Silicon
2 participants
@elopez @montyly