-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI):removing solc-select install all lines #1546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
.github/workflows/IR.yml
Outdated
@@ -34,8 +34,7 @@ jobs: | |||
- name: Install dependencies | |||
run: | | |||
pip install ".[dev]" | |||
solc-select install all | |||
solc-select use 0.8.11 | |||
solc-select use 0.8.11--always-install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a space between the version and the --always-install
flag:
solc-select use 0.8.11--always-install | |
solc-select use 0.8.11 --always-install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok thankyou! sorry for the mess
This reverts commit 23d77e2.
i am adding 2 more installations to pass tests.. instead of specific version |
solc-select use 0.4.25 --always-install | ||
solc-select use 0.8.0 --always-install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, almost there. You'll have to do something similar to this to get the IR tests passing eg update it to look something like this:
- name: Install dependencies
run: |
pip install ".[dev]"
solc-select install 0.5.0
solc-select use 0.8.11 --always-install
- name: Install old solc
if: matrix.os == 'ubuntu-latest'
run: solc-select install 0.4.0
IR tests require 0.5.0 and 0.4.0 except not on windows because that binary is not available.
Note: only one solc version can be use
d at a time, so you can also just install
multiple solc versions and only use
the last one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok got it thankyou
This is great. Thanks @Pavan-Nambi |
issue #1543 (comment)