Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI):removing solc-select install all lines #1546

Merged
merged 7 commits into from
Jan 9, 2023

Conversation

Pavan-Nambi
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@elopez elopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

.github/workflows/IR.yml Outdated Show resolved Hide resolved
@@ -34,8 +34,7 @@ jobs:
- name: Install dependencies
run: |
pip install ".[dev]"
solc-select install all
solc-select use 0.8.11
solc-select use 0.8.11--always-install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a space between the version and the --always-install flag:

Suggested change
solc-select use 0.8.11--always-install
solc-select use 0.8.11 --always-install

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok thankyou! sorry for the mess

@Pavan-Nambi
Copy link
Contributor Author

Pavan-Nambi commented Jan 4, 2023

i am adding 2 more installations to pass tests.. instead of specific version
correct me if this approach is wrong...
thankyou

Comment on lines +58 to +59
solc-select use 0.4.25 --always-install
solc-select use 0.8.0 --always-install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, almost there. You'll have to do something similar to this to get the IR tests passing eg update it to look something like this:

      - name: Install dependencies
        run: |
          pip install ".[dev]"
          solc-select install 0.5.0
          solc-select use 0.8.11 --always-install

      - name: Install old solc
        if: matrix.os == 'ubuntu-latest'
        run: solc-select install 0.4.0

IR tests require 0.5.0 and 0.4.0 except not on windows because that binary is not available.
Note: only one solc version can be used at a time, so you can also just install multiple solc versions and only use the last one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok got it thankyou

@Pavan-Nambi Pavan-Nambi requested review from bohendo and removed request for elopez January 6, 2023 02:40
@montyly
Copy link
Member

montyly commented Jan 9, 2023

This is great. Thanks @Pavan-Nambi

@montyly montyly merged commit a6ca165 into crytic:dev Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants