tests: source_unit: remove incomplete submodule #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elopez
changed the title
elopez
force-pushed
the
dev-fix-docker-build
branch
from
6f401ab
to
1ea1f6d
Compare
elopez
force-pushed
the
dev-fix-docker-build
branch
from
1ea1f6d
to
55c2428
Compare
montyly
reviewed
Jan 6, 2023
tests/test_source_unit.py
Outdated
| @@ -1,5 +1,7 @@ | |||
| from slither import Slither | |||
|
|
|||
| # NB: read tests/source_unit/README.md before using this test | |||
There was a problem hiding this comment.
Could we detect if this was not done in the test itself, and raise a warning in pytest?
There was a problem hiding this comment.
I added a skipif, it will skip the test if deps are not met + log a skip reason
This fixes some issues with the Docker build process
* missing `git` in wheel build process - pip requires Git to pull
dependencies expressed as `foo @ git+https://...`.
* pip upgrade before building - it was disabled with an extra `echo`
Thanks to @ahpaleus for reporting this!
* final image installation - pip insists on rebuilding git-referenced
dependencies, so this installs the wheels directly with `--no-deps`
to get the desired behavior.
elopez
force-pushed
the
dev-fix-docker-build
branch
from
0bae2d6
to
48c7548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.