Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve inheritance printers #162

Merged
merged 1 commit into from Feb 5, 2019
Merged

Improve inheritance printers #162

merged 1 commit into from Feb 5, 2019

Conversation

montyly
Copy link
Member

@montyly montyly commented Feb 4, 2019

@montyly
Printers modifications:
331868d 
        - inheritance-graph: don't show redundant edges (close #157)
        - inheritance: separate immediate/non immediate fathers/children
@montyly montyly requested a review from Xenomega February 4, 2019 23:39
Xenomega
Xenomega approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@Xenomega Xenomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, output is as expected, no seemingly problematic code. It's worth noting some contracts inherit directly and indirectly and the inheritance printer will show the immediate and not indirect (no duplicates), which is absolutely fine behavior.

@montyly montyly merged commit 87f3be5 into dev Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xenomega Xenomega Xenomega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@montyly @Xenomega