New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove core.children #1673

Merged

montyly merged 2 commits into dev from dev-remove-core-children

Mar 22, 2023

Member

montyly commented Feb 20, 2023

core.children ended up making the API harder to maintain and was not really providing useful API.

This PR replaces it:

Most of the elements are removed/integrated into the derived classes
Only ChildContract is kept, but it is move to declarations.ContractLevel and it is meant to be used in contrast to TopLevel


          Remove core.children

10109fc

montyly requested review from 0xalpharush and smonicas as code owners

February 20, 2023 10:35


          Black

43a27fb

This was referenced Feb 20, 2023

Add more types hints #1666

Merged

Next release checklist #1693

Closed

montyly merged commit c3ce0a8 into dev

montyly deleted the dev-remove-core-children branch

March 22, 2023 18:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment