Improvements on <Modifying storage array by value> detector #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bossjoker1
requested review from
montyly,
0xalpharush and
smonicas
as code owners
|
|
|
Sorry, I just don't know what caused this check(slither-read-storage) to fail. |
|
@bossjoker1 It's unrelated to your PR. If you merge dev into your branch, the CI should pass. |
|
@0xalpharush: can you resolve the merge conflicts? |
0xalpharush
added a commit
that referenced
this pull request
Jun 10, 2023
0xalpharush
pushed a commit
that referenced
this pull request
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to issue#1679 . And I added the relevant test case.