Improved interface code generation in slither.utils.code_generation
#1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
especially contract-type variables and functions that return them
including ArrayType vars and user-defined contract types
webthethird
requested review from
montyly,
0xalpharush and
smonicas
as code owners
semicolon and new line
…nterface-code # Conflicts: # tests/unit/utils/test_data/code_generation/TEST_generated_code_not_unrolled.sol
0xalpharush
reviewed
Apr 18, 2023
0xalpharush
reviewed
Apr 18, 2023
with list comprehension outside
|
Any other changes needed to get this one ready to merge? |
0xalpharush
approved these changes
Apr 27, 2023
|
It'd be cool to expose this as a tool for etherscan |
|
@montyly I think this PR is ready to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes unrolling structs in function parameters and returns optional, and adds more robust testing