Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect when ether is sent in Yul #1909

Merged
merged 5 commits into from
Jun 8, 2023
Merged

Detect when ether is sent in Yul #1909

merged 5 commits into from
Jun 8, 2023

Conversation

smonicas
Copy link
Contributor

Fix #1686

@0xalpharush
Copy link
Member

Storing the result of nest boolean expressions in variables with clear names and then using the variables in the condition would probably eliminate the pylint warning and be cleaner

@0xalpharush 0xalpharush merged commit adabce6 into dev Jun 8, 2023
49 checks passed
@0xalpharush 0xalpharush deleted the fix-yul-ether-locked branch June 8, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xalpharush 0xalpharush 0xalpharush left review comments

@montyly montyly Awaiting requested review from montyly montyly is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smonicas @0xalpharush