fix: make _convert_to_structure_to_list return a type instead of an ElementaryType's type field
#1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Would you mind making this against the dev branch please? |
kevinclancy
force-pushed
the
upstream-pr/struct-destruct-fix
branch
from
b623dcd
to
3419be0
Compare
…tary type's type field
kevinclancy
force-pushed
the
upstream-pr/struct-destruct-fix
branch
from
3419be0
to
e651d3d
Compare
0xalpharush
reviewed
Jun 4, 2023
slither/slithir/convert.py
Outdated
Comment on lines
1586
to
1589
| if isinstance(return_type, (ElementaryType, UserDefinedType, TypeAlias)): | ||
| return [return_type] | ||
|
|
||
| assert False |
There was a problem hiding this comment.
Could we change the isinstance check to an assert instead of asserting False?
0xalpharush
reviewed
Jun 4, 2023
slither/slithir/convert.py
Outdated
Comment on lines
1586
to
1589
| if isinstance(return_type, (ElementaryType, UserDefinedType, TypeAlias)): | ||
| return [return_type] | ||
|
|
||
| assert False |
There was a problem hiding this comment.
Suggested change
| if isinstance(return_type, (ElementaryType, UserDefinedType, TypeAlias)): | |
| return [return_type] | |
| assert False | |
| assert isinstance(return_type, (ElementaryType, UserDefinedType, TypeAlias)) | |
| return [return_type] |
|
Can you format this please? |
|
Yes. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1918