Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue which disallowed using operator[] with TopLevelVariables #1968

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

Tiko7454
Copy link
Contributor

bytes16 constant HEX = '0123456789ABCDEF';

contract C {
    function f(uint i) public {
        HEX[1];
    }
}

This code was throwing an assertion error due to HEX was expected to be an lvalue, but it doesn't need to be

@Tiko7454 Tiko7454 requested a review from montyly as a code owner June 16, 2023 15:21
@0xalpharush 0xalpharush changed the base branch from master to dev June 16, 2023 15:46
@0xalpharush 0xalpharush added this to the 0.9.4 milestone Jun 20, 2023
@0xalpharush
Copy link
Member

Would you mind making this PR against the dev branch please?

@montyly montyly merged commit 69bf3bb into crytic:dev Jun 23, 2023
40 checks passed
@montyly
Copy link
Member

montyly commented Jun 23, 2023

Nice catch, thanks @Tiko7454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants