Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/vyper support #2099

Merged
merged 71 commits into from Oct 12, 2023
Merged

Feat/vyper support #2099

merged 71 commits into from Oct 12, 2023

Conversation

0xalpharush
Copy link
Member

@0xalpharush 0xalpharush commented Aug 29, 2023 •
edited

TODO

  • fix bug with phi placement in internal functions
  • disable slither tools
  • add break/continue to CFG
  • functions with nonreentrant("lock") should return False for Function.is_reentrant
  • AST parsing/ CFG tests
  • support tuples types chainlink_lrd: (0: uint80, int256, uint256, uint256, uint80)
  • functions with only Pass in the body should return False for Function.is_implemeted
  • make sure refinements like convert_constant_types only run on Solidity

Follow up

  • rename solidity types, SolidityCall, SolidityFunction to builtin
  • figure out what to do with reentrancy analysis when functions have nonreentrant(<param>) and param > 1
  • support imports
  • update max value of enum types
  • implement rest of interfaces e.g. ERC165
  • attach references in find_variable
  • add detector tests
  • make sure builtins are represented faithfully

@0xalpharush
WIP
7b3e064
@0xalpharush
improve parse_types
b264512
@0xalpharush
fix interface referring to constants, plus comments
90dc42f
@0xalpharush
check in progress on comparison operators and builtins
b142d23
@0xalpharush
aug assign op
6fd82fe
@0xalpharush
wip rewrite of for loops
75c3389
@0xalpharush
more builtins; support params, state vars in loop iterators
2f94d1c
@0xalpharush
support enum bitwise comparison operations
872d9b5
@0xalpharush
add some builtin variables for vyper
7549341
@0xalpharush
allow type conversion to array type for vyper
fd7c130
@0xalpharush
add anon. local for return signature
a8641d2
@0xalpharush
support conversion of interface to address, lookup interface funcs
4c78fe0
@0xalpharush
handle stldib interfaces
cff917f
@0xalpharush
initialized vars with expr
3e461ca
@0xalpharush
perform ssa conversion and analysis
71894ba
@0xalpharush
remove unused code
b1cb181
@0xalpharush
fix type
b537b70
@0xalpharush
fix div symbol
8a3fb6a
@0xalpharush
improve comparison operator support, set_offset of expressions
472efb9
@0xalpharush
control flow graph (loops and ifs)
011c03a
@0xalpharush
more builtins
6bd52fa
@0xalpharush
fix source mapping, set source code and source unit
5443132
@0xalpharush
parse bool op symbol
a61ca34
@0xalpharush
add support for self.balance
4b07cbb
@0xalpharush
fmt
db88cd5
@0xalpharush
rename fixture
85e63c6
@0xalpharush
convert raw_call to LowLevelCall
55ab580
@0xalpharush
handle edge case for vyper Expr nodes
4c1ad51
@0xalpharush
add ability to perform filtering by language to AbstractDetector
2bfe829
@0xalpharush
delete unused code, misc. notes
77637d9
@0xalpharush
convert tuple on lhs and index access to struct and field access
3ca9d0f
@0xalpharush
consider function unimplemented if body is only pass
47e274c
@0xalpharush
do not considered local variable that are reference types as `in_stor…
66def31 
…age`
@0xalpharush
fix phi placement by calling SlitherCompilationUnit.add_function
e287b2f
@0xalpharush
support default args in calls
81cb124
@0xalpharush
fix and refactor comparison operator, add support for raise
4845a3b
@0xalpharush
conditionally apply refinements to Solidity
9fdc7dc
@0xalpharush
cleanup and formatting
16140f2
@0xalpharush
handle break/continue
9c4bc50
@0xalpharush
update tests
9df54e9
@0xalpharush
cleanup
a6209df
@0xalpharush
fix some lint warnings
c217980
@0xalpharush
add struct defs to file scope
e80238d
@0xalpharush
propagate return type on call to state variable with interface type
239369c
@0xalpharush
more cleanup
e8fa8b8
@0xalpharush
address lints and improve typing
961db45
@0xalpharush
link issues for TODO comments, lint
404914c
@0xalpharush 0xalpharush marked this pull request as ready for review September 5, 2023 19:32
@montyly montyly merged commit 9e003ee into dev Oct 12, 2023
83 checks passed
@montyly montyly deleted the feat/vyper-support branch October 12, 2023 14:45
This was referenced Oct 18, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elopez elopez Awaiting requested review from elopez elopez is a code owner

@montyly montyly Awaiting requested review from montyly montyly is a code owner

@smonicas smonicas Awaiting requested review from smonicas smonicas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xalpharush @montyly