Refactor reentrancy + API changes #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move can reenter / can send eth logics to the IR level - Add create-based reentrancy (#310)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans the reentrancy fix point module by moving part of the logic to the IR level. The reentrancy detector will be easier to read and maintain. Additionally, other modules can benefit from the re-enter and ethers sent information.
Changes:
can_renterandcan_send_etherfunctions for all theCallIRs. Additionally, these functions are accessible at thenodeandfunctionlevel.This PR needs extra testing to ensure that the heuristics are correctly conserved.