Refactor of slither-upgradeability-check #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only the logic contract is needed, proxy becomes optional - Change flag name - Clean main to ease the add of new checks - Clean variable ordering logic; merge the two function into one generic (fix #274) - Refactor json output and add source mapping (fix #347). The json output needs to be tested - Add check for constant conformance (fix #188) - Overall output improvements
- add missing file - Test constant conformance - Test variable initilization - Minor change in output
|
This PR is now based on the upcoming JSON refactoring: #355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several improvements on the upgradeability checks:
The json output and the constant conformance checks need to be tested.
The documentation needs to be updated to merge this PR.