WIP: cli improvements #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirtixs
force-pushed
the
feature/cli-improvements
branch
2 times, most recently
from
90ef3de
to
006d14b
Compare
benstew
reviewed
Oct 22, 2018
|
@redshark1802 - Looking good. Just provided some brief feedback to keep the output consistent with how it was previously. |
kirtixs
force-pushed
the
feature/cli-improvements
branch
3 times, most recently
from
eea60d9
to
bde212d
Compare
disconnect3d
approved these changes
Oct 23, 2018
benstew
reviewed
Oct 23, 2018
| * `--printer-inheritance`: Print the inheritance relations | ||
| * `--printer-inheritance-graph`: Print the inheritance graph in a file | ||
| * `--printer-vars-and-auth`: Print the variables written and the check on `msg.sender` of each function | ||
| By default, the `contract-summary` printer is used. Use --printers comma-separated list of printers, |
There was a problem hiding this comment.
Thanks for cleaning this up a little, looking good 👍
benstew
reviewed
Oct 23, 2018
README.md
Outdated
|
|
||
| ## Checks available | ||
| * `contract-summary`: Print a summary of the contracts | ||
| * `quick-summary`: Print a quick summary of the contracts |
There was a problem hiding this comment.
nitpick - might use quick-contract-summary for clarity
There was a problem hiding this comment.
oh, it's a typo, the printer was renamed function-summary https://github.com/trailofbits/slither/wiki/Printer-documentation#function-summary
There was a problem hiding this comment.
The printer quick-summary doesn't exist, I removed it from the list.
kirtixs
force-pushed
the
feature/cli-improvements
branch
5 times, most recently
from
4b23ad7
to
f3de8fe
Compare
- help is printed when no arguments are supplied - rework detector arguments: detectors are now a comma-separated list, defaults to all - rework printer arguments: printers are now a comma-separated list, defaults to contract-summary - add version command - add --list-detectors and --list-printers - update README
kirtixs
force-pushed
the
feature/cli-improvements
branch
from
f3de8fe
to
f6ed3ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #50