Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.md
Summary of changes
Fixed reverse debugging commands that were broken when
--gdb
flag was removed.Before this fix, replaying an rr recording would force all debugging commands to be run in reverse mode, with no checkbox available to override the setting.
Also pinned
mypy
to its previous version, since the latest update broke linting and caused all CI to fail.Test plan
Tested by building the executable with
nox --sessions build_executable_linux
, then ran gdbgui on a previously recorded rr session withand confirmed reverse debugging commands (and the UI itself -- tooltips, etc.) were behaving as expected.
Also ran normally with