Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reverse debugging commands #365

Merged
merged 3 commits into from Dec 1, 2020
Merged

Conversation

loganwendholt
Copy link
Contributor

@loganwendholt loganwendholt commented Nov 30, 2020

  • I have added an entry to docs/changelog.md

Summary of changes

Fixed reverse debugging commands that were broken when --gdb flag was removed.

Before this fix, replaying an rr recording would force all debugging commands to be run in reverse mode, with no checkbox available to override the setting.

Also pinned mypy to its previous version, since the latest update broke linting and caused all CI to fail.

Test plan

Tested by building the executable with nox --sessions build_executable_linux, then ran gdbgui on a previously recorded rr session with

./gdbgui_0.14.0.2 --gdb-cmd "rr replay --"

and confirmed reverse debugging commands (and the UI itself -- tooltips, etc.) were behaving as expected.

Also ran normally with

./gdbgui_0.14.0.2

@cs01
Copy link
Owner

cs01 commented Nov 30, 2020

Thanks for this! Looks like I broke it during that update, my bad. LGTM but the lint job is failing.

@loganwendholt
Copy link
Contributor Author

Linter issue should be fixed, but I did just spot one last-minute typo -- will push again in just a sec.

@loganwendholt
Copy link
Contributor Author

Should be good to go!

@cs01 cs01 merged commit 7644258 into cs01:master Dec 1, 2020
@cs01
Copy link
Owner

cs01 commented Dec 1, 2020

Thanks again 😃

@loganwendholt loganwendholt deleted the reverse-fix branch December 1, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants