-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill in missing skeleton files from whitelist projects #572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine; just fix the build and you can merge.
@@ -33,7 +33,8 @@ angular.module('seashell-projects', ['seashell-websocket', 'marmoset-bindings']) | |||
var SKEL_ROOT_URL = CS136_URL + "assignment_skeletons/"; | |||
// TODO: update with real template path. | |||
var PROJ_ZIP_URL_TEMPLATE = SKEL_ROOT_URL + "%s-seashell.zip"; | |||
var PROJ_FILE_LIST_URL_TEMPLATE = CGI_URL + "skeleton_file_list.rkt?template=%s"; | |||
var USERNAME = $cookies.getObject(SEASHELL_CREDS_COOKIE).user; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add user to the dummy credentials cookies that we use for the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the dummy cookie created? I can't seem to find it after a lot of searching
https://github.com/cs136/seashell/blob/master/src/tests/frontend-tests/lib/creds.js On Sun, Sep 18, 2016 at 12:33 PM, Kaleb Alway notifications@github.com
Edward Lee |
Saw that, but that's just the name of the cookie. Is there somewhere where a dummy cookie is created or should I just save a cookie here? |
I thought it was created there, but I guess not. I think it's alright to On Sun, Sep 18, 2016 at 3:24 PM, Kaleb Alway notifications@github.com
Edward Lee |
No description provided.