Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in missing skeleton files from whitelist projects #572

Merged
merged 5 commits into from
Sep 19, 2016

Conversation

kpalway
Copy link
Contributor

@kpalway kpalway commented Sep 15, 2016

No description provided.

Copy link
Contributor

@e45lee e45lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine; just fix the build and you can merge.

@@ -33,7 +33,8 @@ angular.module('seashell-projects', ['seashell-websocket', 'marmoset-bindings'])
var SKEL_ROOT_URL = CS136_URL + "assignment_skeletons/";
// TODO: update with real template path.
var PROJ_ZIP_URL_TEMPLATE = SKEL_ROOT_URL + "%s-seashell.zip";
var PROJ_FILE_LIST_URL_TEMPLATE = CGI_URL + "skeleton_file_list.rkt?template=%s";
var USERNAME = $cookies.getObject(SEASHELL_CREDS_COOKIE).user;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add user to the dummy credentials cookies that we use for the tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the dummy cookie created? I can't seem to find it after a lot of searching

@e45lee
Copy link
Contributor

e45lee commented Sep 18, 2016

https://github.com/cs136/seashell/blob/master/src/tests/frontend-tests/lib/creds.js

On Sun, Sep 18, 2016 at 12:33 PM, Kaleb Alway notifications@github.com
wrote:

@kpalway commented on this pull request.

In src/frontend/js/project-service.js
#572:

@@ -33,7 +33,8 @@ angular.module('seashell-projects', ['seashell-websocket', 'marmoset-bindings'])
var SKEL_ROOT_URL = CS136_URL + "assignment_skeletons/";
// TODO: update with real template path.
var PROJ_ZIP_URL_TEMPLATE = SKEL_ROOT_URL + "%s-seashell.zip";

  •  var PROJ_FILE_LIST_URL_TEMPLATE = CGI_URL + "skeleton_file_list.rkt?template=%s";
    
  •  var USERNAME = $cookies.getObject(SEASHELL_CREDS_COOKIE).user;
    

Where is the dummy cookie created? I can't seem to find it after a lot of
searching


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#572, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADK8iu0HLiI9_tWwgTJ84SM2JAyA6Ku2ks5qrWfHgaJpZM4J-Psg
.

Edward Lee

@kpalway
Copy link
Contributor Author

kpalway commented Sep 18, 2016

Saw that, but that's just the name of the cookie. Is there somewhere where a dummy cookie is created or should I just save a cookie here?

@e45lee
Copy link
Contributor

e45lee commented Sep 18, 2016

I thought it was created there, but I guess not. I think it's alright to
save a cookie there.

On Sun, Sep 18, 2016 at 3:24 PM, Kaleb Alway notifications@github.com
wrote:

Saw that, but that's just the name of the cookie. Is there somewhere where
a dummy cookie is created or should I just save a cookie here?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#572 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADK8ilOumF5dk78bBpViAVQslv1NoxYxks5qrY_fgaJpZM4J-Psg
.

Edward Lee

@e45lee e45lee merged commit b8598ea into cs136:master Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants