Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booking date #174

Closed
nus-se-bot opened this issue Apr 5, 2019 · 1 comment
Closed

Booking date #174

nus-se-bot opened this issue Apr 5, 2019 · 1 comment

Comments

@nus-se-bot
Copy link

Describe the bug
I am able to do booking at year 0000 or any past years

To Reproduce
Steps to reproduce the behavior:

  1. addbooking c/1 ts/0000-02-23T14:30 n/3

Expected behavior
Should not be able to make a booking for last year or earlier

Screenshots
Screenshot 2019-04-05 at 2 57 53 PM

Additional context
Add any other context about the problem here.


Reported by: @NgWeiXin
Severity: Medium

[original: nus-cs2103-AY1819S2/pe-dry-run#550]

@lingyanhao
Copy link

This is more of an acceptance rather than a system test- indeed we might want to consider restricting the date range.

Currently, the system does not provide any guarantee on what dates should be accepted.

However, is becomes unclear what the "correct" threshold should be. More than a year ago? More than a month ago? More than a day ago? Anything into the past?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants