Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year for deadlines are not fully sanitized #117

Closed
nus-se-bot opened this issue Apr 5, 2019 · 1 comment
Closed

Year for deadlines are not fully sanitized #117

nus-se-bot opened this issue Apr 5, 2019 · 1 comment

Comments

@nus-se-bot
Copy link

Describe the bug
Able to create HW due from 1600-9999, but 1599 doesn't work. Able to create deadlines already past (and waaay past)

To Reproduce
Steps to reproduce the behavior:

  1. Enter any valid add-hw command, except set the year to 1600 to 2018.

Expected behavior
HW is rejected for dates before current time, or accepted for dates before 1600

Screenshots
image


Reported by: @eugenefdw
Severity: Low

[original: nus-cs2103-AY1819S2/pe-dry-run#235]

@NgWeiXin
Copy link

NgWeiXin commented Apr 9, 2019

Checking of deadlines has been implemented in latest version.

@NgWeiXin NgWeiXin closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants