Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing wrong error message for invalid parameters #117

Closed
nus-se-bot opened this issue Apr 5, 2019 · 0 comments
Closed

Showing wrong error message for invalid parameters #117

nus-se-bot opened this issue Apr 5, 2019 · 0 comments
Assignees
Projects
Milestone

Comments

@nus-se-bot
Copy link

Describe the bug
When invalid parameters are used (eg. c/) for addBook and editBook, the error message does not identify these as invalid. Rather, the application treats them as part of the input for the previous valid parameter, making the program not work as intended.

To Reproduce
Steps to reproduce the behavior:

  1. Type 'editBook 6 t/fantasy n/One Year of Solitude a/John Mayer m/5 c/Yes'

  2. See error about incorrect input to the m/ parameter instead of the invalid c/ parameter

  3. Type 'addBook t/fantasy n/Two Years of Solitude c/hello m/5 a/John Mayer'

  4. See incorrect behaviour - no error is produced and the 'c/hello' is added to the name of the book

Expected behavior
Either the invalid parameter tag should be ignored, or an error saying that it is an invalid parameter should be shown.

Screenshots
image

image


Reported by: @whyjayxp
Severity: Medium

[original: nus-cs2103-AY1819S2/pe-dry-run#397]

@0blivious 0blivious self-assigned this Apr 5, 2019
@0blivious 0blivious added this to To do in v1.4 Apr 6, 2019
@0blivious 0blivious added this to the v1.4 milestone Apr 11, 2019
v1.4 automation moved this from To do to Done Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v1.4
  
Done
Development

No branches or pull requests

2 participants