New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show version number rather than commit in sysinfo service #2953

Open

labkode opened this issue Jun 13, 2022 · 1 comment

Member

labkode commented Jun 13, 2022 •

edited

Sometimes the version number shown in the sysinfo service used by ScienceMesh is a commit ID rather than the tagged version.

The build info is taken from the build tags:

reva/cmd/revad/main.go

Line 56 in a8c6140

    
           if err := sysinfo.InitSystemInfo(&sysinfo.RevaVersion{Version: version, BuildDate: buildDate, GitCommit: gitCommit, GoVersion: goVersion}); err != nil {

so I think we just need to make sure that the packaged reva version in the ArtifactHub is the one with a tag.

labkode assigned SamuAlfageme and unassigned SamuAlfageme

Member Author

labkode commented Jun 23, 2022

@dagl can you please take this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment